diff options
| author | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-12-11 15:50:25 +0000 |
|---|---|---|
| committer | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-12-11 15:50:25 +0000 |
| commit | 3ecb43c5968fbfc48cebf4c5307fef1441a67c29 (patch) | |
| tree | 9fe95a3b9aa37c779de07871de6409ab76da526f | |
| parent | 7f1b5075acffcf0e711b07addf51c6e5d2e42274 (diff) | |
round-robin.sh: Allow non-broken components to advance their revisions
... when failure occurs in non-interesting components.
Change-Id: Ic58fe08b048704a21830959105e20fab62935b82
| -rw-r--r-- | round-robin.sh | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/round-robin.sh b/round-robin.sh index bb30807e..b15521cb 100644 --- a/round-robin.sh +++ b/round-robin.sh @@ -591,15 +591,17 @@ No reason to rebase base-artifacts." trigger_dest="$run_step_artifacts" fi - # 1. If $score is less-than 0, then the regression is uninteresting, - # don't bisect. + # 1. If $score is less-than 0, then the regression is not very + # interesting, so reduce down to component, but don't bisect. This + # allows non-broken components to advance their revisions. # 2. Otherwise, trigger builds with narrowed-down list of updated # components -- by generating trigger-build-* files. Also generate # these files as a favor to round-robin-bisect.sh script. # 3. Otherwise, we have narrowed-down regression to a single component, # so trigger bisect build for this component -- by generating - # trigger-bisect file. - if [ $score -lt 0 ] 2>/dev/null; then + # trigger-bisect file. Note that the negative "! [ $score -lt 0 ]" + # condition is to handle non-numeric scores like "all" and "boot". + if [ $score -lt 0 ] 2>/dev/null && [ x"${rr[mode]}" = x"bisect" ]; then # Don't bisect uninteresting regressions. : elif [ x"$single_component" = x"" ] || [ x"${rr[mode]}" = x"bisect" ]; then @@ -618,7 +620,7 @@ No reason to rebase base-artifacts." fi done > $trigger_dest/trigger-build-$update_components2 done < <(${rr[breakup_updated_components]}) - else + elif ! [ $score -lt 0 ] 2>/dev/null; then # Bisect failures in all steps after "-1" step. local baseline_rev cur_rev baseline_rev=$(git_rev_parse_long $single_component ${rr[baseline_branch]} baseline) |