summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Kuvyrkov <maxim.kuvyrkov@linaro.org>2021-01-06 09:59:49 +0000
committerMaxim Kuvyrkov <maxim.kuvyrkov@linaro.org>2021-01-13 16:54:44 +0000
commite3dff5bb41b4350ed1d84a10b4e703b0b07f7285 (patch)
tree042d3d3f6f2576de653ede698417014d0916d493
parent8b78dcbbb58168994aa58ac649c430c1227d0f6d (diff)
round-robin-bisect.sh: Remove obsolete marker
We used to rely on $artifacts/first-bad file as a marker in our CI round-robin loops, but have switched to trigger-* files many moons ago. Change-Id: I5039827b2a24543d1088fae5bf11a7e50a78b3b6
-rwxr-xr-xround-robin-bisect.sh9
1 files changed, 4 insertions, 5 deletions
diff --git a/round-robin-bisect.sh b/round-robin-bisect.sh
index 152dde25..ce8617f3 100755
--- a/round-robin-bisect.sh
+++ b/round-robin-bisect.sh
@@ -426,8 +426,7 @@ if [ x"$first_bad" != x"" ]; then
done
if [ x"$last_good" != x"" ]; then
- # Success! Touch $artifacts/first-bad as a marker of successful bisect.
- echo $first_bad > $artifacts/first-bad
+ # We have successfully identified a bad commit with a good parent!
# Add both $last_good and $first_bad to interesting commits.
push_interesting_commit $last_good "last-good"
push_interesting_commit $first_bad "regression"
@@ -537,7 +536,7 @@ find "$current_project" -path "$current_project/.git/BISECT_*" -print0 | xargs -
# Remove any fail-safe email body
rm -f $artifacts/jenkins/mail-body.txt
-if [ -f $artifacts/first-bad ]; then
+if [ x"$first_bad" != x"" ]; then
mkdir -p $artifacts/jenkins
sed -i -e "s/\$/-$first_bad/" $artifacts/jenkins/build-name
@@ -580,7 +579,7 @@ Could not identify regression in *$current_project* in CI configuration ${rr[ci_
EOF
fi
-if [ x"${JIRA_PASSWORD+set}" = x"set" ] && [ -f $artifacts/first-bad ]; then
+if [ x"${JIRA_PASSWORD+set}" = x"set" ] && [ x"$first_bad" != x"" ]; then
case "${rr[ci_project]}/${rr[ci_config]}" in
tcwg_kernel/gnu-*) jira_card="GNU-587" ;;
tcwg_kernel/llvm-*) jira_card="LLVM-480" ;;
@@ -690,7 +689,7 @@ Artifacts: ${BUILD_URL}artifact/$rel_artifacts/
Build log: ${BUILD_URL}consoleText
EOF
-if [ -f $artifacts/first-bad ]; then
+if [ x"$first_bad" != x"" ]; then
cat >> $artifacts/jenkins/mail-body.txt <<EOF
Full commit (up to 1000 lines):