diff options
| author | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-03-05 11:18:54 +0000 |
|---|---|---|
| committer | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-03-11 10:23:24 +0000 |
| commit | 73c89ab411102bb4627505de7a617ee8fe372657 (patch) | |
| tree | bf73c4da7956978bef68f3c40a81d7f3ab358a6e /tcwg_bmk-build.sh | |
| parent | 170d72fbc6ea94f1224e460d2e34a6b13f018f0a (diff) | |
Add annotations to round-robin's "results" file
Annotations provide human-readable comments and data on regressions.
For this we ignore all lines in "results" file starting with "#".
Change-Id: I31328fe2c13895a7379137b00891a9d2fc0a39d7
Diffstat (limited to 'tcwg_bmk-build.sh')
| -rwxr-xr-x | tcwg_bmk-build.sh | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/tcwg_bmk-build.sh b/tcwg_bmk-build.sh index 7152d485..e066e3a3 100755 --- a/tcwg_bmk-build.sh +++ b/tcwg_bmk-build.sh @@ -243,6 +243,7 @@ compare_results () local ref_results_id="$1" local new_results_id="$2" local cmp_options="$3" + local annotate_results="$4" local results_ref results_new results_ref=$(cat $ref_results_id) @@ -304,6 +305,9 @@ compare_results () esac if ! [ "$metric" -le "$threshold" ]; then result=100 + if $annotate_results; then + echo "# $bmk,$symbol regressed by $metric" >> $run_step_top_artifacts/results + fi else result=1 fi @@ -337,7 +341,7 @@ no_regression_vs_p () if ! [ -f "$ref_artifacts/results_id-1" -a -f "$ref_artifacts/results_id-2" ]; then return 0 fi - compare_results "$ref_artifacts/results_id-1" "$ref_artifacts/results_id-2" "--num_dsos 1 --num_symbols 0" + compare_results "$ref_artifacts/results_id-1" "$ref_artifacts/results_id-2" "--num_dsos 1 --num_symbols 0" false for i in $(find $run_step_artifacts/ -type f -name "results*"); do mv $i $(dirname $i)/ref-$(basename $i) done @@ -346,7 +350,7 @@ no_regression_vs_p () if ! [ -f "$new_artifacts/results_id-1" -a -f "$new_artifacts/results_id-2" ]; then return 1 fi - compare_results "$new_artifacts/results_id-1" "$new_artifacts/results_id-2" "--num_dsos 1 --num_symbols 0" + compare_results "$new_artifacts/results_id-1" "$new_artifacts/results_id-2" "--num_dsos 1 --num_symbols 0" false for i in $(find $run_step_artifacts/ -type f -name "results*"); do mv $i $(dirname $i)/new-$(basename $i) done @@ -385,6 +389,7 @@ no_regression_vs_p () result=${arr[2]} if ! [ "$result" -le "5000" ]; then echo "Regression in $bmk,$symbol" | tee -a $new_artifacts/regressions.txt + echo "# $bmk,$symbol regressed" >> $new_artifacts/results status=1 if [ x"$bmk" != x"$prev_bmk" ]; then bisect_bmks+=("++benchmarks" "$bmk") @@ -419,7 +424,7 @@ no_regression_to_base_p () case "${cflags[0]}" in *"_LTO"*) compare_opts="--num_symbols 0 --entry_threshold 10" ;; esac - compare_results "$ref_artifacts/results_id" "$new_artifacts/results_id" "$compare_opts" + compare_results "$ref_artifacts/results_id" "$new_artifacts/results_id" "$compare_opts" true local bmk symbol result status prev_bmk local -a bisect_bmks |