Age | Commit message (Collapse) | Author |
|
Now using the version that's
present in the bionic images.
Meaning we have more warnings
but can also set the minimum
level to ignore a lot of them.
Fix the check for whether
shellcheck supports --severity.
(we have pipefail on, but we
expect shellcheck to fail in
this case)
Change-Id: I296b8554591b7d327c75393e3924184abc6512b7
|
|
First round of low hanging fruit
from the files with the fewest
warnings.
Change-Id: I60ad57b5bfb2f0be9bb6506252c820f44d055200
|
|
This reverts commit 70dc16911c9b438dfff0ee8ad48d2fd5cb355e02.
Reason for revert: The underlying problem was wrong (outdate)
ssh configuration on dev-01.tcwglab, which caused PWD directory.
Change-Id: I75e0e08f4a75b0217193d0192a49f32d3f42a8c5
|
|
Otherwise we get the following error message. Note that both
03a87b31a8fcd76b361dfc2fcb21b716413487a3 and remote refs/heads/tested
are verified to be regular commits. Not sure why this is happening, but
working around this should be OK.
===
00:05:14.720 + git -C jenkins-scripts push gerrit 03a87b31a8fcd76b361dfc2fcb21b716413487a3:refs/heads/tested
00:05:16.027 To ssh://tcwg-buildslave@review.linaro.org:29418/toolchain/jenkins-scripts.git
00:05:16.027 ! [rejected] 03a87b31a8fcd76b361dfc2fcb21b716413487a3 -> tested (needs force)
00:05:16.027 error: failed to push some refs to 'ssh://tcwg-buildslave@review.linaro.org:29418/toolchain/jenkins-scripts.git'
00:05:16.027 hint: You cannot update a remote ref that points at a non-commit object,
00:05:16.027 hint: or update a remote ref to make it point at a non-commit object,
00:05:16.027 hint: without using the '--force' option.
===
Change-Id: I8821f77e37d1faa229a77718c3c322cde62b1e87
|
|
Replace ${var:-default} with ${var-default}.
I learned something new about shell scripting today. From bash manual:
===
When not performing substring expansion, using the form described
below (e.g., ‘:-’), Bash tests for a parameter that is unset or null.
Omitting the colon results in a test only for a parameter that is
unset. Put another way, if the colon is included, the operator tests
for both parameter’s existence and that its value is not null; if
the colon is omitted, the operator tests only for existence.
===
The immediate problem I need to fix is handling of
host_aarchXX_excludecheck and host_x86_64_excludecheck parameters
in tcwg-buildfarm.sh. With ":-" syntax the empty ("null") values are
replaced by defaults, causing GCC testsuite to be ignored on aarchXX
hosts when "--host_aarchXX_excludecheck ''" is given.
There happens to be a single usage ":-" in ${rw:-rw} in
start-container-qemu.sh, where ":-" is actually needed.
Change-Id: Ibc8e070b698e1c76e2161eb65d40639b8cdec1f3
|
|
Change-Id: I8aebd07199319b7b6c063870b27883f342f4adde
|
|
Change-Id: If1ba5a74b988a55ee04d252cec8bf064c952cd97
|
|
Change-Id: I396de4eab96af4938de724429f8f35fc35f39dd8
|
|
Change-Id: I5cecb64ffe897e1a2d7d4a4ad3dca6fb9195f69e
|
|
Change-Id: I5e1ffde89556e5063d68d93335603006e0c81bf2
|