From 0604d8b81bfd01b4040dd6611ba69c23a0082aa1 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Mon, 2 Aug 2021 10:28:42 +0000 Subject: round-robin-bisect.sh: Better handle spurious regressions Change-Id: I503aa7a3fd718fd2cd5b20f279e097fbf8f2f015 --- round-robin-bisect.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/round-robin-bisect.sh b/round-robin-bisect.sh index a7494e13..9b94b715 100755 --- a/round-robin-bisect.sh +++ b/round-robin-bisect.sh @@ -225,14 +225,14 @@ EOF if [ x"$baseline_rev" = x"$bad_rev" ]; then echo "WARNING: Detected regression with no change in sources of $current_project" sed -i -e "s/\$/-no_change/" $artifacts/jenkins/build-name - trap "" EXIT - exit 1 + res=0 +else + # Confirm regression in $bad_rev vs $baseline_rev. + git checkout --detach $bad_rev + $artifacts/test.sh & + res=0 && wait $! || res=$? fi -# Confirm regression in $bad_rev vs $baseline_rev. -git checkout --detach $bad_rev -$artifacts/test.sh & -res=0 && wait $! || res=$? # Restore revision previously checked out. Otherwise "git bisect run" # below will not use replay info. git checkout --detach $prev_rev -- cgit v1.2.3