From c0e26f3027e4a6c623d1f392cbb9f4fa3ac856cf Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Fri, 29 May 2020 16:36:58 +0000 Subject: round-robin-bisect.sh: Fix shellcheck warnings Change-Id: Id9495fa4785702f155bc845f4db1f8b7691e9a48 --- round-robin-bisect.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/round-robin-bisect.sh b/round-robin-bisect.sh index cd387a0c..004196ee 100755 --- a/round-robin-bisect.sh +++ b/round-robin-bisect.sh @@ -18,6 +18,7 @@ convert_args_to_variables "$@" shift "$SHIFT_CONVERTED_ARGS" obligatory_variables bad_url bad_branch build_script current_project +declare bad_url bad_branch build_script current_project BUILD_URL="${BUILD_URL:-$(pwd)}" replay_log="${replay_log-}" @@ -28,8 +29,9 @@ convert_args_to_variables ^^ $reproduce_bisect %% $artifacts/manifests/build-par $reproduce_bisect || manifest_pop obligatory_variables rr[ci_project] rr[ci_config] +declare -A rr -verbose="${verbose:-true}" +verbose="${verbose-true}" set -u @@ -44,7 +46,6 @@ trap "eval \"echo ERROR at \${FUNCNAME[0]}:\${BASH_LINENO[0]}\" > $artifacts/fai rebase_workaround=false rebase_workaround_opts=() -# shellcheck disable=SC2154 case "${rr[ci_project]}/${rr[ci_config]}:$current_project" in tcwg_kernel/*-next-*:linux) # Workaround linux-next/master rebasing on top of linux-next/stable. @@ -66,7 +67,6 @@ esac # Build baseline that we are going to re-use to speed-up bisection. # (This also confirms that infrastructure is OK.) echo "Testing baseline (should be success)" -# shellcheck disable=SC2154 $build_script \ ^^ $reproduce_bisect \ %% $rel_artifacts/manifests/build-baseline.sh \ -- cgit v1.2.3