From f8c64dd09a2e99af95c4a739b706e958d6f16d8a Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov Date: Tue, 17 Mar 2020 13:07:01 +0000 Subject: round-robin.sh: Avoid changing top-level artifacts in no_regression_p predicate The no_regression_p() predicate function is called from two steps: check_regression and update_baseline. While we want no_regression_p to output regression info during check_regression step, we don't want that during update_baseline (during update_baseline no_regression_p is called to compare current results against pre-baseline ones). To fix the above we generate regression information in artifacts directory of the current step, and copy it to the top-level only during check_regression step. Change-Id: Ib03d82f7afe60c406c7942f2fa086855df371171 --- tcwg_gnu-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tcwg_gnu-build.sh') diff --git a/tcwg_gnu-build.sh b/tcwg_gnu-build.sh index bb42040a..a81b2076 100755 --- a/tcwg_gnu-build.sh +++ b/tcwg_gnu-build.sh @@ -105,7 +105,7 @@ no_regression_p () # We use GCC's comparison script, so make sure we have a copy (may # not be the case when we are just checking binutils) clone_or_update_repo gcc master git://gcc.gnu.org/git/gcc.git - gcc/contrib/compare_tests $sumfiles_base $sumfiles_new | tee $new_artifacts/regressions.txt & + gcc/contrib/compare_tests $sumfiles_base $sumfiles_new | tee $run_step_artifacts/regressions.txt & res=0 && wait $! || res=$? if [ $res -ne 0 ]; then -- cgit v1.2.3