diff options
| author | ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524> | 2011-07-05 08:24:22 +0000 |
|---|---|---|
| committer | ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524> | 2011-07-05 08:24:22 +0000 |
| commit | 715cf6dd7e7ab5c42152983e72a3bfe84258ff6d (patch) | |
| tree | 6b8b323a242d2828d0a5ecfbc52c07496cd7b0b0 /MdeModulePkg | |
| parent | d88ca2c90d49eb08649a905bdeacfb6feba81cf3 (diff) | |
Refine code to avoid potential access violation.
Signed-off-by:ydong10
Reviewed-by:lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11976 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdeModulePkg')
| -rw-r--r-- | MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 | ||||
| -rw-r--r-- | MdeModulePkg/Universal/SetupBrowserDxe/Ui.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c index 2fdc0bfbc..863097d00 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -1168,7 +1168,7 @@ ProcessCallBackFunction ( // "retrieve" should update to the question's temp buffer.
//
if (Action == EFI_BROWSER_ACTION_CHANGING || Action == EFI_BROWSER_ACTION_RETRIEVE) {
- SetQuestionValue(Selection->FormSet,Selection->Form, Question,TRUE);
+ SetQuestionValue(Selection->FormSet, Selection->Form, Statement, TRUE);
}
} else if (Status == EFI_UNSUPPORTED) {
//
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c index 5c8d67618..44b4d774b 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c @@ -2877,6 +2877,7 @@ UiDisplayMenu ( AdjustDateAndTimePosition (TRUE, &NewPos);
if (NewPos->BackLink != &gMenuOption) {
MenuOption = MENU_OPTION_FROM_LINK (NewPos);
+ ASSERT (MenuOption != NULL);
NewLine = TRUE;
NewPos = NewPos->BackLink;
@@ -2888,7 +2889,6 @@ UiDisplayMenu ( }
NextMenuOption = MENU_OPTION_FROM_LINK (NewPos);
- ASSERT (MenuOption != NULL);
if (Difference < 0) {
//
// We hit the begining MenuOption that can be focused
|