diff options
author | Wolfram Sang <wsa@the-dreams.de> | 2013-04-19 21:12:17 +0200 |
---|---|---|
committer | Kamal Mostafa <kamal@canonical.com> | 2013-08-15 10:59:17 -0700 |
commit | 078810d0dbda86f194b467c9f3dcb6d5661e0105 (patch) | |
tree | 9bf5a94c0d5b5255e8f9a460f67f1dd10a83df2b | |
parent | 84550642539bb25a8129373419545ca6e955d86d (diff) |
serial: mxs: fix buffer overflow
commit 4829e7650f8a40645e4e32b26a37fb833a5e75f0 upstream.
SMATCH correctly found an off-by-one error:
drivers/tty/serial/mxs-auart.c:889 auart_console_write() error: buffer overflow 'auart_port' 5 <= 5
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
-rw-r--r-- | drivers/tty/serial/mxs-auart.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c index f0d17ee2aaed..6b00fa523b78 100644 --- a/drivers/tty/serial/mxs-auart.c +++ b/drivers/tty/serial/mxs-auart.c @@ -885,7 +885,7 @@ auart_console_write(struct console *co, const char *str, unsigned int count) unsigned int old_ctrl0, old_ctrl2; unsigned int to = 1000; - if (co->index > MXS_AUART_PORTS || co->index < 0) + if (co->index >= MXS_AUART_PORTS || co->index < 0) return; s = auart_port[co->index]; |