diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-10-29 22:07:47 +0300 |
---|---|---|
committer | Kamal Mostafa <kamal@canonical.com> | 2013-11-07 17:43:40 -0800 |
commit | f9fc704132b2c8cffc319d0156a5db78e5c958de (patch) | |
tree | a924a5ee0b9a5ff444206cfe5c93d4fdcb74ef75 | |
parent | 364d11a0f36ed035a0adf09699da8d8b710a553c (diff) |
staging: ozwpan: prevent overflow in oz_cdev_write()
commit c2c65cd2e14ada6de44cb527e7f1990bede24e15 upstream.
We need to check "count" so we don't overflow the ei->data buffer.
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
-rw-r--r-- | drivers/staging/ozwpan/ozcdev.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 64913aeb0bac..f9c493b84d1b 100644 --- a/drivers/staging/ozwpan/ozcdev.c +++ b/drivers/staging/ozwpan/ozcdev.c @@ -152,6 +152,9 @@ ssize_t oz_cdev_write(struct file *filp, const char __user *buf, size_t count, struct oz_app_hdr *app_hdr; struct oz_serial_ctx *ctx; + if (count > sizeof(ei->data) - sizeof(*elt) - sizeof(*app_hdr)) + return -EINVAL; + spin_lock_bh(&g_cdev.lock); pd = g_cdev.active_pd; if (pd) |