diff options
| author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-06-07 17:25:35 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-11 16:58:57 -0700 |
| commit | e26d925f42064a800c1226e15dbaa23da1721fb7 (patch) | |
| tree | dca6ae8201998a008419c5b39a304375eec792c7 /drivers/staging/comedi/drivers/pcl816.c | |
| parent | 0bdf8ec0a57e5c4f90f4d6e83938f24653360d84 (diff) | |
staging: comedi: pcl816: if test should use logical OR not bitwise OR
This quiets a couple sparse warnings about:
warning: dubious: !x | !y
warning: dubious: x | !y
Also, remove the unnecessary parentheses abound the variables.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/comedi/drivers/pcl816.c')
| -rw-r--r-- | drivers/staging/comedi/drivers/pcl816.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c index 277a23ece6fa..845039cd6207 100644 --- a/drivers/staging/comedi/drivers/pcl816.c +++ b/drivers/staging/comedi/drivers/pcl816.c @@ -414,8 +414,8 @@ static irqreturn_t interrupt_pcl816(int irq, void *d) } outb(0, dev->iobase + PCL816_CLRINT); /* clear INT request */ - if ((!dev->irq) | (!devpriv->irq_free) | (!devpriv->irq_blocked) | - (!devpriv->int816_mode)) { + if (!dev->irq || !devpriv->irq_free || !devpriv->irq_blocked || + !devpriv->int816_mode) { if (devpriv->irq_was_now_closed) { devpriv->irq_was_now_closed = 0; /* comedi_error(dev,"last IRQ.."); */ |