diff options
| author | Jon Medhurst (Tixy) <tixy@linaro.org> | 2015-06-01 12:35:25 +0100 |
|---|---|---|
| committer | Kevin Hilman <khilman@linaro.org> | 2015-06-01 13:52:38 -0700 |
| commit | 107d4a259350eba2ed9b777b84126e8fa6e343e0 (patch) | |
| tree | 4a897e1d5f08f46de024ce4d62242120b0d75888 /include | |
| parent | fa482af8eb41c823506bef2efa612a1db63dabd5 (diff) | |
Revert "mm: make vmstat_update periodic run conditional"
This reverts commit 7d252cd22a3f6cb459e8b012912dfd258157f7df because it
has been implicated in kernel crashes when its workqueue timer is
migrated during CPU hotplug.
When HMP was initially being developed against a 3.4 derived kernel, it
was observed that wakeups were occurring every 30s across every core to
give the vmstat accounting a kick. This was causing a noticeable
increase in energy consumption on the really quiet use cases such as
audio and video playback. So commit 7d252cd22a was used which turned off
the updates on idle CPUs to reduce that.
On the 3.10 derived LSK this revert does not result in a significant
increase in power consumption so it is assumed that changes since 3.4
have mitigated the initial problem.
Signed-off-by: Jon Medhurst <tixy@linaro.org>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/vmstat.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index a30ab7910ff4..c586679b6fef 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -198,7 +198,7 @@ extern void __inc_zone_state(struct zone *, enum zone_stat_item); extern void dec_zone_state(struct zone *, enum zone_stat_item); extern void __dec_zone_state(struct zone *, enum zone_stat_item); -bool refresh_cpu_vm_stats(int); +void refresh_cpu_vm_stats(int); void refresh_zone_stat_thresholds(void); void drain_zonestat(struct zone *zone, struct per_cpu_pageset *); |