summaryrefslogtreecommitdiff
path: root/drivers/of
diff options
context:
space:
mode:
authorBrian Norris <computersforpeace@gmail.com>2014-09-03 11:06:43 -0700
committerGrant Likely <grant.likely@linaro.org>2014-09-08 15:57:24 +0100
commit5f74d8b7b8546255db6af45b017e9cbb18aed609 (patch)
treef1dd714d88d5c668c0f38a97d6bf297ac55581f2 /drivers/of
parent2ce7598c9a453e0acd0e07be7be3f5eb39608ebd (diff)
of: correct of_console_check()'s return value
The comments above of_console_check() say that it will return TRUE if it registers a preferred console, but add_preferred_console() uses a 0-equals-success convention, so this leaves of_console_check() with an inconsistent policy for its return values. Fortunately, nobody was actually checking the return value of of_console_check(), so this isn't significant at the moment. But let's match the comments, so we're doing what we say. Fixes: 3482f2c52b77 ('of: Create of_console_check() for selecting a console specified in /chosen') Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Grant Likely <grant.likely@linaro.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/base.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c
index d8574adf0d62..bcfd08c2795c 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1986,7 +1986,7 @@ bool of_console_check(struct device_node *dn, char *name, int index)
{
if (!dn || dn != of_stdout || console_set_on_cmdline)
return false;
- return add_preferred_console(name, index, NULL);
+ return !add_preferred_console(name, index, NULL);
}
EXPORT_SYMBOL_GPL(of_console_check);