diff options
author | Sam Clegg <sbc@chromium.org> | 2019-10-17 03:21:02 +0000 |
---|---|---|
committer | Sam Clegg <sbc@chromium.org> | 2019-10-17 03:21:02 +0000 |
commit | 3dafd644af855246f057cebff67557663dd0e4b9 (patch) | |
tree | 43b41e4dd138eb6a8a47e4a37a662f500968992f /test | |
parent | 3a000037f13f9d26ef6a1c497916f24c661a3cc2 (diff) |
[lld][WebAssembly] Fix for weak references to data symbols in archives
Fix a bug where were not handling relocations against weakly undefined
data symbol. Add a test for this case. Also ensure that the weak
references to data symbols are not pulled in from archive files by
default (but are if `-u <name>` is added to the command line).
Fixes: PR43696
Differential Revision: https://reviews.llvm.org/D69073
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@375077 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test')
-rw-r--r-- | test/wasm/archive-weak-undefined.ll | 26 |
1 files changed, 23 insertions, 3 deletions
diff --git a/test/wasm/archive-weak-undefined.ll b/test/wasm/archive-weak-undefined.ll index 0285724e5..25afccaba 100644 --- a/test/wasm/archive-weak-undefined.ll +++ b/test/wasm/archive-weak-undefined.ll @@ -1,19 +1,39 @@ +; Test that weak undefined symbols do not fetch members from archive files. ; RUN: llc -filetype=obj %s -o %t.o -; RUN: llc -filetype=obj %S/Inputs/ret32.ll -o %t.a1.o +; RUN: llc -filetype=obj %S/Inputs/ret32.ll -o %t.ret32.o +; RUN: llc -filetype=obj %S/Inputs/hello.ll -o %t.hello.o ; RUN: rm -f %t.a -; RUN: llvm-ar rcs %t.a %t.a1.o +; RUN: llvm-ar rcs %t.a %t.ret32.o %t.hello.o + ; RUN: wasm-ld %t.o %t.a -o %t.wasm ; RUN: obj2yaml %t.wasm | FileCheck %s +; RUN: wasm-ld -u hello_str %t.o %t.a -o %t2.wasm +; RUN: obj2yaml %t2.wasm | FileCheck %s -check-prefix=CHECK-DATA + target triple = "wasm32-unknown-unknown" +; Weak external function symbol declare extern_weak i32 @ret32() +; Weak external data symbol +@hello_str = extern_weak global i8*, align 4 + define void @_start() { -entry: + br i1 icmp ne (i8** @hello_str, i8** null), label %if.then, label %if.end + +if.then: %call1 = call i32 @ret32() + br label %if.end + +if.end: ret void } +; Ensure we have no data section. If we do, would mean that hello_str was +; pulled out of the library. +; CHECK-NOT: Type: DATA +; CHECK-DATA: Type: DATA + ; CHECK: Name: 'undefined:ret32' ; CHECK-NOT: Name: ret32 |