aboutsummaryrefslogtreecommitdiff
path: root/zorg
diff options
context:
space:
mode:
authorGalina Kistanova <gkistanova@gmail.com>2019-10-17 04:07:11 +0000
committerGalina Kistanova <gkistanova@gmail.com>2019-10-17 04:07:11 +0000
commit84b11957d35c021b934db4ee2e43cf1d85bd926d (patch)
treecba878d5fcc1d7ac9099421b9010ac6adcf131c6 /zorg
parent3607aef29ae456e47c2de2d09e204400e3e5d373 (diff)
ClangBuilder code cleaning. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/zorg/trunk@375078 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'zorg')
-rw-r--r--zorg/buildbot/builders/ClangBuilder.py39
1 files changed, 25 insertions, 14 deletions
diff --git a/zorg/buildbot/builders/ClangBuilder.py b/zorg/buildbot/builders/ClangBuilder.py
index 2ed6f668..96e1fdf1 100644
--- a/zorg/buildbot/builders/ClangBuilder.py
+++ b/zorg/buildbot/builders/ClangBuilder.py
@@ -413,14 +413,14 @@ def getClangCMakeGCSBuildFactory(
# Test-suite
runTestSuite=False,
- nt_flags=[],
- testsuite_flags=[],
+ nt_flags=None,
+ testsuite_flags=None,
submitURL=None,
testerName=None,
# Environmental variables for all steps.
- env={},
- extra_cmake_args=[],
+ env=None,
+ extra_cmake_args=None,
# Extra repositories
checkout_clang_tools_extra=True,
@@ -437,7 +437,7 @@ def getClangCMakeGCSBuildFactory(
use_pixz_compression=False,
# Triggers
- trigger_after_stage1=[]):
+ trigger_after_stage1=None):
return _getClangCMakeBuildFactory(
clean=clean, test=test, cmake=cmake, jobs=jobs, vs=vs,
vs_target_arch=vs_target_arch, useTwoStage=useTwoStage,
@@ -474,14 +474,14 @@ def getClangCMakeBuildFactory(
# Test-suite
runTestSuite=False,
- nt_flags=[],
- testsuite_flags=[],
+ nt_flags=None,
+ testsuite_flags=None,
submitURL=None,
testerName=None,
# Environmental variables for all steps.
- env={},
- extra_cmake_args=[],
+ env=None,
+ extra_cmake_args=None,
# Extra repositories
checkout_clang_tools_extra=True,
@@ -522,14 +522,14 @@ def _getClangCMakeBuildFactory(
# Test-suite
runTestSuite=False,
- nt_flags=[],
- testsuite_flags=[],
+ nt_flags=None,
+ testsuite_flags=None,
submitURL=None,
testerName=None,
# Environmental variables for all steps.
- env={},
- extra_cmake_args=[],
+ env=None,
+ extra_cmake_args=None,
# Extra repositories
checkout_clang_tools_extra=True,
@@ -547,9 +547,20 @@ def _getClangCMakeBuildFactory(
use_pixz_compression=False,
# Triggers
- trigger_after_stage1=[]):
+ trigger_after_stage1=None):
############# PREPARING
+ if nt_flags is None:
+ nt_flags = []
+ if testsuite_flags is None:
+ testsuite_flags = []
+ if env is None:
+ env = {}
+ if extra_cmake_args is None:
+ extra_cmake_args = []
+ if trigger_after_stage1 is None:
+ trigger_after_stage1 = []
+
clean_build_requested = lambda step: \
step.build.getProperty( \
"clean", \