diff options
author | Jinfeng Ni <jni@apache.org> | 2016-09-21 16:03:49 -0700 |
---|---|---|
committer | Jinfeng Ni <jni@apache.org> | 2016-10-05 20:40:46 -0700 |
commit | 4edabe7a392f38b0f7a9c8af51a74bf6932a821d (patch) | |
tree | befeaca14754d136fcd64316738e3d6ab9deed0a /exec | |
parent | 1375a0065f1acae4ff5edf3c6370b7ad25f188c4 (diff) |
DRILL-4911: Avoid plan serialization in SimpleParallelizer when debug logging is not enabled.
Diffstat (limited to 'exec')
2 files changed, 12 insertions, 4 deletions
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java index 47de88e7c..c389e89cd 100644 --- a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java +++ b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java @@ -316,11 +316,15 @@ public class SimpleParallelizer implements ParallelizationParameters { .build(); if (isRootNode) { - logger.debug("Root fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + if (logger.isDebugEnabled()) { + logger.debug("Root fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + } rootFragment = fragment; rootOperator = root; } else { - logger.debug("Remote fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + if (logger.isDebugEnabled()) { + logger.debug("Remote fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + } fragments.add(fragment); } } diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/SplittingParallelizer.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/SplittingParallelizer.java index 3488e7f41..395a9e1f4 100644 --- a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/SplittingParallelizer.java +++ b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/SplittingParallelizer.java @@ -211,11 +211,15 @@ public class SplittingParallelizer extends SimpleParallelizer { .build(); if (isRootNode) { - logger.debug("Root fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + if (logger.isDebugEnabled()) { + logger.debug("Root fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + } rootFragment = fragment; rootOperator = root; } else { - logger.debug("Remote fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + if (logger.isDebugEnabled()) { + logger.debug("Remote fragment:\n {}", DrillStringUtils.unescapeJava(fragment.toString())); + } throw new ForemanSetupException(String.format("There should not be non-root/remote fragment present in plan split, but there is:", DrillStringUtils.unescapeJava(fragment.toString()))); } |