summaryrefslogtreecommitdiff
path: root/drivers/pci/pci_config.c
diff options
context:
space:
mode:
authorYonattan Louise <yonattan.a.louise.mendoza@intel.com>2015-05-14 16:30:48 -0500
committerAnas Nashif <anas.nashif@intel.com>2016-02-05 20:13:59 -0500
commitdbada63eee8516d35d11c1543788e742b70172e1 (patch)
tree6f6556441918eecadd2495e4e2944138422accf5 /drivers/pci/pci_config.c
parentd133f9661d670ca5340dd032ba3630f44d995af9 (diff)
Fix coding style issues.
Some checkpatch issues were solved by scripts leaving other problems such as alignment and indentation issues. In order to comply with the defined coding style the following fixes were made: - Fixed the function declaration moving the parameters' comments above the function in accordance to the doxygen format. - Fixed functions' opening and closing brackets. These brackets should not be indented. - Fixed the 'if', 'for' and 'while' statements adding the brackets around the sentence. - Fixed comments' alignment. - Fixed indentation. The work was done manually and submitted as one commit. I didn't separate these changes in different commits because they were fixed all at once. Basically, all errors were fixed in every file at once. Change-Id: Icc94a10bfd2cff82007ce60df23b2ccd4c30268d Signed-off-by: Yonattan Louise <yonattan.a.louise.mendoza@intel.com>
Diffstat (limited to 'drivers/pci/pci_config.c')
-rw-r--r--drivers/pci/pci_config.c109
1 files changed, 62 insertions, 47 deletions
diff --git a/drivers/pci/pci_config.c b/drivers/pci/pci_config.c
index d2259ece9..f07e09a59 100644
--- a/drivers/pci/pci_config.c
+++ b/drivers/pci/pci_config.c
@@ -58,14 +58,16 @@ This module implements the PCI config space access functions
*
* pci_config_out_long - write a 32bit data to pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number
+* @param func_no Function number
+* @param offset Offset into the configuration space.
+* @param data Data written to the offset.
+*
* RETURNS: N/A
*/
-void pci_config_out_long(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint32_t data /* data written to the offset */
- )
+void pci_config_out_long(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint32_t data)
{
union pci_addr_reg pci_addr;
@@ -86,14 +88,16 @@ void pci_config_out_long(uint32_t bus_no, /* bus number */
*
* pci_config_out_word - write a 16bit data to pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number.
+* @param func_no Function number.
+* @param offset Offset into the configuration space.
+* @param data Data written to the offset.
+*
* RETURNS: N/A
*/
-void pci_config_out_word(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint16_t data /* data written to the offset */
- )
+void pci_config_out_word(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint16_t data)
{
union pci_addr_reg pci_addr;
@@ -114,14 +118,16 @@ void pci_config_out_word(uint32_t bus_no, /* bus number */
*
* pci_config_out_byte - write a 8bit data to pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number.
+* @param func_no Function number.
+* @param offset Offset into the configuration space.
+* @param data Data written to the offset.
+*
* RETURNS: N/A
*/
-void pci_config_out_byte(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint8_t data /* data written to the offset */
- )
+void pci_config_out_byte(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint8_t data)
{
union pci_addr_reg pci_addr;
@@ -142,15 +148,17 @@ void pci_config_out_byte(uint32_t bus_no, /* bus number */
*
* pci_config_in_long - read a 32bit data from pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number.
+* @param func_no Function number.
+* @param offset Offset into the configuration space.
+* @param data Data read from the offset.
+*
* RETURNS: N/A
*
*/
-void pci_config_in_long(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint32_t *data /* data read from the offset */
- )
+void pci_config_in_long(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint32_t *data)
{
union pci_addr_reg pci_addr;
@@ -171,16 +179,18 @@ void pci_config_in_long(uint32_t bus_no, /* bus number */
*
* pci_config_in_word - read in a 16bit data from a pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number.
+* @param func_no Function number.
+* @param offset Offset into the configuration space.
+* @param data Data read from the offset.
+*
* RETURNS: N/A
*
*/
-void pci_config_in_word(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint16_t *data /* data read from the offset */
- )
+void pci_config_in_word(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint16_t *data)
{
union pci_addr_reg pci_addr;
uint32_t pci_data;
@@ -206,16 +216,18 @@ void pci_config_in_word(uint32_t bus_no, /* bus number */
*
* pci_config_in_byte - read in a 8bit data from a pci reg in offset
*
+* @param bus_no Bus number.
+* @param device_no Device number.
+* @param func_no Function number.
+* @param offset Offset into the configuration space.
+* @param data Data read from the offset.
+*
* RETURNS: N/A
*
*/
-void pci_config_in_byte(uint32_t bus_no, /* bus number */
- uint32_t device_no, /* device number */
- uint32_t func_no, /* function number */
- uint32_t offset, /* offset into the configuration space */
- uint8_t *data /* data read from the offset */
- )
+void pci_config_in_byte(uint32_t bus_no, uint32_t device_no, uint32_t func_no,
+ uint32_t offset, uint8_t *data)
{
union pci_addr_reg pci_addr;
uint32_t pci_data;
@@ -245,17 +257,19 @@ void pci_config_in_byte(uint32_t bus_no, /* bus number */
* capabilities in config space. If found, the offset of the first byte
* of the capability of interest in config space is returned via pOffset.
*
+* @param ext_cap_find_id Extended capabilities ID to search for.
+* @param bus PCI bus number.
+* @param device PCI device number.
+* @param function PCI function number.
+* @param p_offset Returned config space offset.
+*
* RETURNS: 0 if Extended Capability found, -1 otherwise
*
*/
-int pci_config_ext_cap_ptr_find(
- uint8_t ext_cap_find_id, /* Extended capabilities ID to search for */
- uint32_t bus, /* PCI bus number */
- uint32_t device, /* PCI device number */
- uint32_t function, /* PCI function number */
- uint8_t *p_offset /* returned config space offset */
- )
+int pci_config_ext_cap_ptr_find(uint8_t ext_cap_find_id, uint32_t bus,
+ uint32_t device, uint32_t function,
+ uint8_t *p_offset)
{
uint16_t tmp_stat;
uint8_t tmp_offset;
@@ -266,8 +280,9 @@ int pci_config_ext_cap_ptr_find(
pci_config_in_word(bus, device, function, PCI_CFG_STATUS, &tmp_stat);
- if ((tmp_stat & PCI_STATUS_NEW_CAP) == 0)
+ if ((tmp_stat & PCI_STATUS_NEW_CAP) == 0) {
return -1;
+ }
/* Get the initial ECP offset and make longword aligned */
@@ -276,8 +291,9 @@ int pci_config_ext_cap_ptr_find(
/* Bounds check the ECP offset */
- if (cap_offset < 0x40)
+ if (cap_offset < 0x40) {
return -1;
+ }
/* Look for the specified Extended Cap item in the linked list */
@@ -294,8 +310,7 @@ int pci_config_ext_cap_ptr_find(
/* Get the offset to the next New Capabilities item */
tmp_offset = cap_offset + (uint8_t)0x01;
- pci_config_in_byte(
- bus, device, function, (int)tmp_offset, &cap_offset);
+ pci_config_in_byte(bus, device, function, (int)tmp_offset, &cap_offset);
}
return -1;