| Age | Commit message (Collapse) | Author |
|---|
|
This is really old school, but a lot of times we have users sending us
copy pasting of codes, and that is the only way to know the version of
the code.
|
|
This is mostly a long term maintenance improvement.
Many coding styles require elimination of trailing whitespace, and
many editors and source code management configurations automatically
gobble up whitespace. When these tools gobble up whitespace, it
complicates reviewing the meaningful code changes.
By removing whitespace on one patch, it makes future
code reviews much easier.
=SCRIPT====================================================================
if which tempfile &>/dev/null; then
TEMPMAKER=tempfile
elif which mktemp &>/dev/null; then
TEMPMAKER=mktemp
else
echo "Cannot find tempfile program." 2>&1
exit 1
fi
MYTEMP=$($TEMPMAKER)
trap 'rm -f $MYTEMP' SIGINT SIGTERM
stripit() {
echo "stripping $1"
sed 's/[ \t]*$//' "$1" > $MYTEMP
cp $MYTEMP "$1"
}
if [ $# -gt 0 ]; then
while [ "$1" != "" ]; do
stripit $1
shift
done
else
while read -t 2; do
stripit $REPLY
done
fi
rm $MYTEMP
=================================================
|
|
|
|
The size of array RWORK in {c,z}dbsqr was given incorrectly.
Previous version for cbdsqr.f read
RWORK is REAL array, dimension (2*N)
if NCVT = NRU = NCC = 0, (max(1, 4*N-4)) otherwise
Now reads
RWORK is REAL array, dimension (4*N)
|
|
|
|
Use \par instead of \details for section.
add a Contributors Section and a Reference Section.
Remove (some) verbatim section when not needed.
Those changes have been done by hand so I am not sure I manage to catch them all.
|
|
|
|
|
|
Doxygen html documentation
|
|
|
|
details
|
|
For case 1, the routine will call DLASCL that requires a 4*N workspace.
Following a bug report from Hatem:
I am calling this function to only compute the singular
values from the bidiagonal matrix I just got after the 2nd stage.
The function comments say that the workspace should be
case 1: 2*N if NCVT = NRU = NCC = 0 (basically no singular vectors computed)
case 2: 4*N-4 otherwise.
I allocated the corresponding size for work in my program (i.e. 2*N) and
call the lapackE interface of this function (LAPACKE_zbdsqr_work).
And I get a "double free or corruption (!prev)" when I deallocate
work.
When I call instead LAPACKE_zbdsqr (I let the wrapper
now doing the allocation of work), it passes.
I looked inside LAPACKE_zbdsqr to check the size of work and
it seems to be 4*N across the board (for both cases 1 and 2).
Now, if I call back LAPACKE_zbdsqr_work and I allocate work
using 4*N, it passes.
Is it a bug?
Thanks for your time,
Hatem
|
|
Those are just cosmetic changes to update version number and various other minor change.
|
|
|
|
|
