diff options
author | Alex Bennée <alex.bennee@linaro.org> | 2017-06-19 11:46:45 +0100 |
---|---|---|
committer | Peter Maydell <peter.maydell@linaro.org> | 2017-06-20 13:57:03 +0100 |
commit | 20f26e0cd5917344e3182411e353f4bb827b7ef8 (patch) | |
tree | 3322341477356b34d659d15df53a4c35eee24933 /risu_reginfo_arm.c | |
parent | 5b60c9f45cd99b5de88727db984912a75f331ccf (diff) |
all: fix up code consistency
This is pretty much a mechanical change where I ran:
indent -kr
Across all the files and then fixed up all but a few violations of:
../../qemu.git/scripts/checkpatch.pl -f *.c *.h > checkpatch.out
Along with heavy use of M-x untabify to make everything consistent.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20170619104655.31104-4-alex.bennee@linaro.org
[PMM: some bits of indent in risu_reginfo_arm.c were not right: fixed]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'risu_reginfo_arm.c')
-rw-r--r-- | risu_reginfo_arm.c | 242 |
1 files changed, 121 insertions, 121 deletions
diff --git a/risu_reginfo_arm.c b/risu_reginfo_arm.c index 5309f3a..0cb9087 100644 --- a/risu_reginfo_arm.c +++ b/risu_reginfo_arm.c @@ -26,47 +26,45 @@ extern int insnsize(ucontext_t *uc); static void reginfo_init_vfp(struct reginfo *ri, ucontext_t *uc) { - // Read VFP registers. These live in uc->uc_regspace, which is - // a sequence of - // u32 magic - // u32 size - // data.... - // blocks. We have to skip through to find the one for VFP. - unsigned long *rs = uc->uc_regspace; - - for (;;) - { - switch (*rs++) - { - case 0: - { + /* Read VFP registers. These live in uc->uc_regspace, which is + * a sequence of + * u32 magic + * u32 size + * data.... + * blocks. We have to skip through to find the one for VFP. + */ + unsigned long *rs = uc->uc_regspace; + + for (;;) { + switch (*rs++) { + case 0: + { /* We didn't find any VFP at all (probably a no-VFP * kernel). Zero out all the state to avoid mismatches. */ int j; - for (j = 0; j < 32; j++) - ri->fpregs[j] = 0; + for (j = 0; j < 32; j++) { + ri->fpregs[j] = 0; + } ri->fpscr = 0; return; - } - case 0x56465001: /* VFP_MAGIC */ - { - /* This is the one we care about. The format (after the size word) - * is 32 * 64 bit registers, then the 32 bit fpscr, then some stuff - * we don't care about. + } + case 0x56465001: /* VFP_MAGIC */ + { + /* This is the one we care about. The format (after + * the size word is 32 * 64 bit registers, then the + * 32 bit fpscr, then some stuff we don't care about. */ int i; /* Skip if it's smaller than we expected (should never happen!) */ - if (*rs < ((32*2)+1)) - { - rs += (*rs / 4); - break; + if (*rs < ((32 * 2) + 1)) { + rs += (*rs / 4); + break; } rs++; - for (i = 0; i < 32; i++) - { - ri->fpregs[i] = *rs++; - ri->fpregs[i] |= (uint64_t)(*rs++) << 32; + for (i = 0; i < 32; i++) { + ri->fpregs[i] = *rs++; + ri->fpregs[i] |= (uint64_t) (*rs++) << 32; } /* Ignore the UNK/SBZP bits. We also ignore the cumulative * exception bits unless we were specifically asked to test @@ -75,7 +73,7 @@ static void reginfo_init_vfp(struct reginfo *ri, ucontext_t *uc) */ ri->fpscr = (*rs) & 0xffff9f9f; if (!test_fp_exc) { - ri->fpscr &= ~0x9f; + ri->fpscr &= ~0x9f; } /* Clear the cumulative exception flags. This is a bit * unclean, but makes sense because otherwise we'd have to @@ -85,114 +83,116 @@ static void reginfo_init_vfp(struct reginfo *ri, ucontext_t *uc) */ (*rs) &= ~0x9f; return; - } - default: + } + default: /* Some other kind of block, ignore it */ rs += (*rs / 4); break; - } - } + } + } } void reginfo_init(struct reginfo *ri, ucontext_t *uc) { - memset(ri, 0, sizeof(*ri)); /* necessary for memcmp later */ - - ri->gpreg[0] = uc->uc_mcontext.arm_r0; - ri->gpreg[1] = uc->uc_mcontext.arm_r1; - ri->gpreg[2] = uc->uc_mcontext.arm_r2; - ri->gpreg[3] = uc->uc_mcontext.arm_r3; - ri->gpreg[4] = uc->uc_mcontext.arm_r4; - ri->gpreg[5] = uc->uc_mcontext.arm_r5; - ri->gpreg[6] = uc->uc_mcontext.arm_r6; - ri->gpreg[7] = uc->uc_mcontext.arm_r7; - ri->gpreg[8] = uc->uc_mcontext.arm_r8; - ri->gpreg[9] = uc->uc_mcontext.arm_r9; - ri->gpreg[10] = uc->uc_mcontext.arm_r10; - ri->gpreg[11] = uc->uc_mcontext.arm_fp; - ri->gpreg[12] = uc->uc_mcontext.arm_ip; - ri->gpreg[14] = uc->uc_mcontext.arm_lr; - ri->gpreg[13] = 0xdeadbeef; - ri->gpreg[15] = uc->uc_mcontext.arm_pc - image_start_address; - // Mask out everything except NZCVQ GE - // In theory we should be OK to compare everything - // except the reserved bits, but valgrind for one - // doesn't fill in enough fields yet. - ri->cpsr = uc->uc_mcontext.arm_cpsr & 0xF80F0000; - - ri->faulting_insn = *((uint16_t*)uc->uc_mcontext.arm_pc); - ri->faulting_insn_size = insnsize(uc); - if (ri->faulting_insn_size != 2) - { - ri->faulting_insn |= (*((uint16_t*)uc->uc_mcontext.arm_pc+1)) << 16; - } - - reginfo_init_vfp(ri, uc); + memset(ri, 0, sizeof(*ri)); /* necessary for memcmp later */ + + ri->gpreg[0] = uc->uc_mcontext.arm_r0; + ri->gpreg[1] = uc->uc_mcontext.arm_r1; + ri->gpreg[2] = uc->uc_mcontext.arm_r2; + ri->gpreg[3] = uc->uc_mcontext.arm_r3; + ri->gpreg[4] = uc->uc_mcontext.arm_r4; + ri->gpreg[5] = uc->uc_mcontext.arm_r5; + ri->gpreg[6] = uc->uc_mcontext.arm_r6; + ri->gpreg[7] = uc->uc_mcontext.arm_r7; + ri->gpreg[8] = uc->uc_mcontext.arm_r8; + ri->gpreg[9] = uc->uc_mcontext.arm_r9; + ri->gpreg[10] = uc->uc_mcontext.arm_r10; + ri->gpreg[11] = uc->uc_mcontext.arm_fp; + ri->gpreg[12] = uc->uc_mcontext.arm_ip; + ri->gpreg[14] = uc->uc_mcontext.arm_lr; + ri->gpreg[13] = 0xdeadbeef; + ri->gpreg[15] = uc->uc_mcontext.arm_pc - image_start_address; + /* Mask out everything except NZCVQ GE + * In theory we should be OK to compare everything + * except the reserved bits, but valgrind for one + * doesn't fill in enough fields yet. + */ + ri->cpsr = uc->uc_mcontext.arm_cpsr & 0xF80F0000; + + ri->faulting_insn = *((uint16_t *) uc->uc_mcontext.arm_pc); + ri->faulting_insn_size = insnsize(uc); + if (ri->faulting_insn_size != 2) { + ri->faulting_insn |= + (*((uint16_t *) uc->uc_mcontext.arm_pc + 1)) << 16; + } + + reginfo_init_vfp(ri, uc); } /* reginfo_is_eq: compare the reginfo structs, returns nonzero if equal */ int reginfo_is_eq(struct reginfo *r1, struct reginfo *r2) { - return memcmp(r1, r2, sizeof(*r1)) == 0; /* ok since we memset 0 */ + return memcmp(r1, r2, sizeof(*r1)) == 0; /* ok since we memset 0 */ } /* reginfo_dump: print the state to a stream, returns nonzero on success */ int reginfo_dump(struct reginfo *ri, FILE *f) { - int i; - if (ri->faulting_insn_size == 2) - fprintf(f, " faulting insn %04x\n", ri->faulting_insn); - else - fprintf(f, " faulting insn %08x\n", ri->faulting_insn); - for (i = 0; i < 16; i++) - { - fprintf(f, " r%d: %08x\n", i, ri->gpreg[i]); - } - fprintf(f, " cpsr: %08x\n", ri->cpsr); - for (i = 0; i < 32; i++) - { - fprintf(f, " d%d: %016llx\n", - i, (unsigned long long)ri->fpregs[i]); - } - fprintf(f, " fpscr: %08x\n", ri->fpscr); - - return !ferror(f); + int i; + if (ri->faulting_insn_size == 2) { + fprintf(f, " faulting insn %04x\n", ri->faulting_insn); + } else { + fprintf(f, " faulting insn %08x\n", ri->faulting_insn); + } + for (i = 0; i < 16; i++) { + fprintf(f, " r%d: %08x\n", i, ri->gpreg[i]); + } + fprintf(f, " cpsr: %08x\n", ri->cpsr); + for (i = 0; i < 32; i++) { + fprintf(f, " d%d: %016llx\n", + i, (unsigned long long) ri->fpregs[i]); + } + fprintf(f, " fpscr: %08x\n", ri->fpscr); + + return !ferror(f); } -int reginfo_dump_mismatch(struct reginfo *m, struct reginfo *a, - FILE *f) +int reginfo_dump_mismatch(struct reginfo *m, struct reginfo *a, FILE *f) { - int i; - fprintf(f, "mismatch detail (master : apprentice):\n"); - - if (m->faulting_insn_size != a->faulting_insn_size) - fprintf(f, " faulting insn size mismatch %d vs %d\n", - m->faulting_insn_size, a->faulting_insn_size); - else if (m->faulting_insn != a->faulting_insn) - { - if (m->faulting_insn_size == 2) - fprintf(f, " faulting insn mismatch %04x vs %04x\n", - m->faulting_insn, a->faulting_insn); - else - fprintf(f, " faulting insn mismatch %08x vs %08x\n", - m->faulting_insn, a->faulting_insn); - } - for (i = 0; i < 16; i++) - { - if (m->gpreg[i] != a->gpreg[i]) - fprintf(f, " r%d: %08x vs %08x\n", i, m->gpreg[i], a->gpreg[i]); - } - if (m->cpsr != a->cpsr) - fprintf(f, " cpsr: %08x vs %08x\n", m->cpsr, a->cpsr); - for (i = 0; i < 32; i++) - { - if (m->fpregs[i] != a->fpregs[i]) - fprintf(f, " d%d: %016llx vs %016llx\n", i, - (unsigned long long)m->fpregs[i], - (unsigned long long)a->fpregs[i]); - } - if (m->fpscr != a->fpscr) - fprintf(f, " fpscr: %08x vs %08x\n", m->fpscr, a->fpscr); - - return !ferror(f); + int i; + fprintf(f, "mismatch detail (master : apprentice):\n"); + + if (m->faulting_insn_size != a->faulting_insn_size) { + fprintf(f, " faulting insn size mismatch %d vs %d\n", + m->faulting_insn_size, a->faulting_insn_size); + } else if (m->faulting_insn != a->faulting_insn) { + if (m->faulting_insn_size == 2) { + fprintf(f, " faulting insn mismatch %04x vs %04x\n", + m->faulting_insn, a->faulting_insn); + } else { + fprintf(f, " faulting insn mismatch %08x vs %08x\n", + m->faulting_insn, a->faulting_insn); + } + } + for (i = 0; i < 16; i++) { + if (m->gpreg[i] != a->gpreg[i]) { + fprintf(f, " r%d: %08x vs %08x\n", i, m->gpreg[i], + a->gpreg[i]); + } + } + if (m->cpsr != a->cpsr) { + fprintf(f, " cpsr: %08x vs %08x\n", m->cpsr, a->cpsr); + } + for (i = 0; i < 32; i++) { + if (m->fpregs[i] != a->fpregs[i]) { + fprintf(f, " d%d: %016llx vs %016llx\n", i, + (unsigned long long) m->fpregs[i], + (unsigned long long) a->fpregs[i]); + } + } + if (m->fpscr != a->fpscr) { + fprintf(f, " fpscr: %08x vs %08x\n", m->fpscr, a->fpscr); + } + + return !ferror(f); } |