diff options
| author | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2018-11-14 14:17:03 +0000 |
|---|---|---|
| committer | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2018-11-26 10:44:43 +0000 |
| commit | d993e2699ac3a33a416bba0058f5bda8158fa309 (patch) | |
| tree | 459ca47930d1f640110227f89f7dc9efd39f71b6 /MakeRelease.job | |
| parent | 1aa722d8a8ff64bf600154a966321e994e4d012d (diff) | |
Don't ignore "null" values in variable expansions
Replace ${var:-default} with ${var-default}.
I learned something new about shell scripting today. From bash manual:
===
When not performing substring expansion, using the form described
below (e.g., ‘:-’), Bash tests for a parameter that is unset or null.
Omitting the colon results in a test only for a parameter that is
unset. Put another way, if the colon is included, the operator tests
for both parameter’s existence and that its value is not null; if
the colon is omitted, the operator tests only for existence.
===
The immediate problem I need to fix is handling of
host_aarchXX_excludecheck and host_x86_64_excludecheck parameters
in tcwg-buildfarm.sh. With ":-" syntax the empty ("null") values are
replaced by defaults, causing GCC testsuite to be ignored on aarchXX
hosts when "--host_aarchXX_excludecheck ''" is given.
There happens to be a single usage ":-" in ${rw:-rw} in
start-container-qemu.sh, where ":-" is actually needed.
Change-Id: Ibc8e070b698e1c76e2161eb65d40639b8cdec1f3
Diffstat (limited to 'MakeRelease.job')
| -rwxr-xr-x | MakeRelease.job | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MakeRelease.job b/MakeRelease.job index 88f5d65f..83d80f20 100755 --- a/MakeRelease.job +++ b/MakeRelease.job @@ -49,7 +49,7 @@ target="" fileserver="" extra= toolchain_config="" -user_workspace="${WORKSPACE:-/home/${USER:-buildslave}/workspace}" +user_workspace="${WORKSPACE-/home/${USER-buildslave}/workspace}" abe_dir= binariesdir= logsdir= |