diff options
| author | Christophe Lyon <christophe.lyon@linaro.org> | 2017-10-11 12:25:49 +0000 |
|---|---|---|
| committer | Christophe Lyon <christophe.lyon@linaro.org> | 2017-10-11 12:25:49 +0000 |
| commit | 1b191231991ae06c1892f2da6a8ce757eeffcdaf (patch) | |
| tree | 06dbefd24aa76cad439f213515a6fa96f1bcd2e5 /abe-bisect.sh | |
| parent | 4569ef3df147ccf4bb708d062ba91e6b5c391173 (diff) | |
abe-bisect-helper.sh: Make use of the number of pass/fail in good.
Consider current commit "good" if it has more passes than GOOD,
and "bad" if it has more failures.
Change-Id: I76b325e3985699b04dd107c4a39c2315b82bef78
Diffstat (limited to 'abe-bisect.sh')
| -rwxr-xr-x | abe-bisect.sh | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/abe-bisect.sh b/abe-bisect.sh index e510fb61..8ce6250d 100755 --- a/abe-bisect.sh +++ b/abe-bisect.sh @@ -68,7 +68,7 @@ echo BAD: $BADSHA1 [ x"$GOODSHA1" = x ] && echo "ERROR: Could not find good commit ($GOOD)" && exit 1 [ x"$BADSHA1" = x ] && echo "ERROR: Could not find bad commit ($BAD)" && exit 1 -# Sanity check: make sure BAD has more failures than GOOD +# Sanity checks on the number of passes/fails in GOOD and BAD pushd ${rundir} ${ABE}/abe.sh --target ${TARGET} gcc=gcc.git@${GOODSHA1} --set runtestflags="${EXP}=${TESTNAME}" --build all --check gcc --excludecheck gdb >& gcc-${GOODSHA1}.log if [ $? -ne 0 ]; then @@ -90,13 +90,15 @@ sums=`find builds/*/${TARGET}/gcc.git~master_rev_${BADSHA1}-stage2/ -name "*.sum bad_nb_fail=$(grep ${TESTNAME} $sums | grep -c FAIL) bad_nb_pass=$(grep ${TESTNAME} $sums | grep -c PASS) +# make sure BAD has more failures than GOOD if [ $bad_nb_fail -le $good_nb_fail ]; then echo "ERROR: BAD ($BAD) does not have more failures ($bad_nb_fail) than GOOD ($GOOD) ($good_nb_fail)" exit 1 fi + popd git bisect good ${GOODSHA1} git bisect bad ${BADSHA1} -RUNDIR=${rundir} ABE=${ABE} EXP=${EXP} TESTNAME=${TESTNAME} TARGET=${TARGET} CPU=${CPU} FPU=${FPU} MODE=${MODE} SIMU=${SIMU} TARGETBOARD=${TARGETBOARD} git bisect run ${mydir}/abe-bisect-helper.sh +RUNDIR=${rundir} ABE=${ABE} EXP=${EXP} TESTNAME=${TESTNAME} TARGET=${TARGET} CPU=${CPU} FPU=${FPU} MODE=${MODE} SIMU=${SIMU} TARGETBOARD=${TARGETBOARD} GOODPASS=${good_nb_pass} GOODFAIL=${good_nb_fail} BADPASS=${bad_nb_pass} BADFAIL=${bad_nb_fail} git bisect run ${mydir}/abe-bisect-helper.sh |