diff options
| author | David Spickett <david.spickett@linaro.org> | 2020-04-23 11:10:08 +0100 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2020-04-28 13:13:46 +0000 |
| commit | 6273fc478b9c95c4ae8d42c9021f9428b1d43811 (patch) | |
| tree | 9564b82cc9e90dc4886835d30cbdea35453b1f53 /round-robin-bisect.sh | |
| parent | 0ce72e970e6cbb6c39469b503cdf65510f4f99d8 (diff) | |
Shellcheck fixes round 3
Now using the version that's
present in the bionic images.
Meaning we have more warnings
but can also set the minimum
level to ignore a lot of them.
Fix the check for whether
shellcheck supports --severity.
(we have pipefail on, but we
expect shellcheck to fail in
this case)
Change-Id: I296b8554591b7d327c75393e3924184abc6512b7
Diffstat (limited to 'round-robin-bisect.sh')
| -rwxr-xr-x | round-robin-bisect.sh | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/round-robin-bisect.sh b/round-robin-bisect.sh index 25bb69c6..d48278b5 100755 --- a/round-robin-bisect.sh +++ b/round-robin-bisect.sh @@ -3,6 +3,7 @@ set -ef -o pipefail scripts=$(dirname $0) +# shellcheck source=jenkins-helpers.sh . $scripts/jenkins-helpers.sh # Relative artifacts are used for generation of manifests and reproduction @@ -290,7 +291,7 @@ push_interesting_commit () if [ x"$kind" = x"regression" ]; then configs=($(grep "^$sha1" ../interesting-commits/$current_project | sed -e "s/^$sha1 *//")) - configs+=(${rr[ci_project]}/${rr[ci_config]}) + configs+=("${rr[ci_project]}"/"${rr[ci_config]}") configs=($(echo "${configs[@]}" | tr ' ' '\n' | sort -u)) sed -i -e "s#^$sha1.*\$#$sha1 ${configs[*]}#" ../interesting-commits/$current_project fi @@ -506,7 +507,7 @@ Could not identify regression in *$current_project* in CI configuration ${rr[ci_ EOF fi -if [ x"${JIRA_PASSWORD+set}" = x"set" -a -f $artifacts/first-bad ]; then +if [ x"${JIRA_PASSWORD+set}" = x"set" ] && [ -f $artifacts/first-bad ]; then case "${rr[ci_project]}/${rr[ci_config]}" in tcwg_kernel/gnu-*) jira_card="GNU-587" ;; tcwg_kernel/llvm-*) jira_card="LLVM-480" ;; |