diff options
author | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-03-17 13:07:01 +0000 |
---|---|---|
committer | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2020-03-22 12:02:08 +0000 |
commit | f8c64dd09a2e99af95c4a739b706e958d6f16d8a (patch) | |
tree | 99fbd184a67250f2b827c3882c5d15be25e285b0 /round-robin.sh | |
parent | 8b1f705fb3f331013cc14402bb199248a17ce7c2 (diff) |
round-robin.sh: Avoid changing top-level artifacts in no_regression_p predicate
The no_regression_p() predicate function is called from two steps:
check_regression and update_baseline. While we want no_regression_p
to output regression info during check_regression step, we don't want
that during update_baseline (during update_baseline no_regression_p
is called to compare current results against pre-baseline ones).
To fix the above we generate regression information in artifacts
directory of the current step, and copy it to the top-level only
during check_regression step.
Change-Id: Ib03d82f7afe60c406c7942f2fa086855df371171
Diffstat (limited to 'round-robin.sh')
-rw-r--r-- | round-robin.sh | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/round-robin.sh b/round-robin.sh index 3f739df7..5301f447 100644 --- a/round-robin.sh +++ b/round-robin.sh @@ -486,7 +486,7 @@ no_build_regression_p () # - "^ERROR:" detects linker errors # - ": undefined reference" detects missing symbols during linking # - "] Error " detects GNU make errors - cat > $new_artifacts/regressions.txt <<EOF + cat > $run_step_artifacts/regressions.txt <<EOF First few build errors in logs: $(cat $new_artifacts/console.log | sed -e 's/"[^"]*"//g' | grep " error:\|^ERROR:\|: undefined reference\|\] Error " | head) EOF @@ -531,6 +531,18 @@ check_regression () return fi + if [ -f $run_step_artifacts/regressions.txt ]; then + # Add regression info generated by no_regression_p to top-level. + cp $run_step_artifacts/regressions.txt ${rr[top_artifacts]}/ + fi + + if [ -f $run_step_artifacts/results.regressions ]; then + # Add regression info generated by no_regression_p to top-level + # results file. + cat $run_step_artifacts/results.regressions \ + >> ${rr[top_artifacts]}/results + fi + # We've got a regression. Generate trigger-* files. local single_component=$(print_single_updated_component) local trigger_dest |