diff options
| author | David Spickett <david.spickett@linaro.org> | 2020-04-20 15:43:57 +0100 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2020-04-20 16:58:38 +0100 |
| commit | b9ecc76e09e95cd3132f1eef572279c1cec68218 (patch) | |
| tree | 926c2b2d6d411ad266f70ee2756083bbbe07c05c /tcwg-llvm-common.sh | |
| parent | 5bc4a8aa4bb4ec6ffc77d0acce0e3370582760d6 (diff) | |
Shellcheck warning fixes
(all error/style level warnings)
SC1035: missing whitespace
SC2068: double quote array expansions
SC2145: argument mixes string and array
SC1066: Don't use $ on the left side of assignments
SC2126: Use grep -c instead of grep|wc
Change-Id: Ia53070d3e2c9aea9f626fdb7b2b5bfc9e1f8e682
Diffstat (limited to 'tcwg-llvm-common.sh')
| -rwxr-xr-x | tcwg-llvm-common.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tcwg-llvm-common.sh b/tcwg-llvm-common.sh index c9ef4140..521d2c12 100755 --- a/tcwg-llvm-common.sh +++ b/tcwg-llvm-common.sh @@ -101,7 +101,7 @@ find_svn_rev() { # Find the largest revision of a list find_last_rev() { local LAST=0 - for rev in $@; do + for rev in "$@"; do [ "$rev" -gt "$LAST" ] && LAST=$rev done echo "$LAST" @@ -123,7 +123,7 @@ has_remote_branch() { is_in_list() { local ITEM="$1" shift - for item in $@; do + for item in "$@"; do if [ "$ITEM" = "$item" ]; then return 0 fi |