diff options
| author | David Spickett <david.spickett@linaro.org> | 2020-04-21 16:06:08 +0100 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2020-04-22 13:53:59 +0100 |
| commit | 2382c087b5f0d51a4556c8c62f4723ab5a0ab7c9 (patch) | |
| tree | 70c781a3087d886dc08a92767b6754991858fd7b /tcwg-upstream2gerrit.sh | |
| parent | 7dac1306e35858ef6485a0abf6222f6e13a28ee0 (diff) | |
Various shellcheck warning fixes
First round of low hanging fruit
from the files with the fewest
warnings.
Change-Id: I60ad57b5bfb2f0be9bb6506252c820f44d055200
Diffstat (limited to 'tcwg-upstream2gerrit.sh')
| -rwxr-xr-x | tcwg-upstream2gerrit.sh | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tcwg-upstream2gerrit.sh b/tcwg-upstream2gerrit.sh index f1fc3fb9..c446b207 100755 --- a/tcwg-upstream2gerrit.sh +++ b/tcwg-upstream2gerrit.sh @@ -2,7 +2,7 @@ set -ef -o pipefail -. $(dirname $0)/jenkins-helpers.sh +. "$(dirname $0)"/jenkins-helpers.sh convert_args_to_variables "$@" # Make shellcheck happy and workaround Jenkins not defining variables @@ -34,7 +34,7 @@ default=$project url= https://patches-$project.linaro.org/xmlrpc/ EOF -last_id=$($pwc list -N 1 -f %{id}) +last_id=$($pwc list -N 1 -f "%{id}") if [ "$last_id" = "" ]; then echo "ERROR: Cannot fetch last patch id." exit 1 @@ -69,6 +69,7 @@ case "$project" in esac patch_file=$(mktemp) +# shellcheck disable=SC2064 trap "rm -f $patch_file /tmp/mydiff.$$" EXIT count="0" |