diff options
| author | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2023-08-31 06:59:40 +0000 |
|---|---|---|
| committer | Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> | 2023-08-31 07:00:53 +0000 |
| commit | 6c061ffa5035fc1dff8bcca1db727e6b3ad822a8 (patch) | |
| tree | 0175db8ed9fa04a958084bb274ab6a31c178141c /tcwg_bmk-build.sh | |
| parent | d458fbe2c0c2124b2d1b6df49f1c45604f34ca1c (diff) | |
tcwg-bmk-build.sh (no_regression_p): Update assert
Change-Id: I009b39d6489f3e3c0b48b554d50750425b855f17
Diffstat (limited to 'tcwg_bmk-build.sh')
| -rwxr-xr-x | tcwg_bmk-build.sh | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/tcwg_bmk-build.sh b/tcwg_bmk-build.sh index 019fe689..7512de2a 100755 --- a/tcwg_bmk-build.sh +++ b/tcwg_bmk-build.sh @@ -339,9 +339,7 @@ benchmark () ) } - # Exit with code 0 if no regression compared to base-artifacts/. -# Inspect build results ./results and performance results in ./results_id. no_regression_p () { ( @@ -359,17 +357,15 @@ no_regression_p () return 0 fi - assert_with_msg "Benchmarking succeeded, but results_id is missing" \ - [ -f $run_step_top_artifacts/results_id ] + assert_with_msg "Benchmarking succeeded, but bmk-data is missing" \ + [ -e $run_step_top_artifacts/annex/bmk-data ] # Make sure there is no stray results.regression file, which we use # as failure marker. assert ! [ -f $run_step_artifacts/results.regressions ] - # At this stage, - # - new/results_id should exist (score>0) - # - ref/results_id might not exist, (ex: baseline score<0) - + # FIXME: Remove custom options for LTO configurations after specific + # thresholds are large enough for symbols. local compare_opts="" case "${rr[target]}:$cflags" in "arm_eabi":*"_LTO"*) compare_opts="--num_symbols 0 --entry_threshold 10 --has_perf_logs no" ;; |