| Age | Commit message (Collapse) | Author |
|---|
|
Change-Id: I78e50e12cd2a2cd1ba239bf2d6cc93097976ed07
|
|
When 'grep' in invoked with -q option, it exits with the first match,
and closes the input pipe. This will break the pipe and scripts running
with "-o pipefail" will get unexpected results.
Replace "<output> | grep -q", with "<output> | grep -q ... >/dev/null"
throught our scripts. Leave "grep -q ... <input_file>" intact, since
pipes are not involved.
Change-Id: I9438919276c0d0e235600384a979b511e1a4edff
|
|
Change-Id: Id6a43557384d05923547fe90a8f488fa3f35c04b
|
|
Now using the version that's
present in the bionic images.
Meaning we have more warnings
but can also set the minimum
level to ignore a lot of them.
Fix the check for whether
shellcheck supports --severity.
(we have pipefail on, but we
expect shellcheck to fail in
this case)
Change-Id: I296b8554591b7d327c75393e3924184abc6512b7
|
|
First round of low hanging fruit
from the files with the fewest
warnings.
Change-Id: I60ad57b5bfb2f0be9bb6506252c820f44d055200
|
|
Replace ${var:-default} with ${var-default}.
I learned something new about shell scripting today. From bash manual:
===
When not performing substring expansion, using the form described
below (e.g., ‘:-’), Bash tests for a parameter that is unset or null.
Omitting the colon results in a test only for a parameter that is
unset. Put another way, if the colon is included, the operator tests
for both parameter’s existence and that its value is not null; if
the colon is omitted, the operator tests only for existence.
===
The immediate problem I need to fix is handling of
host_aarchXX_excludecheck and host_x86_64_excludecheck parameters
in tcwg-buildfarm.sh. With ":-" syntax the empty ("null") values are
replaced by defaults, causing GCC testsuite to be ignored on aarchXX
hosts when "--host_aarchXX_excludecheck ''" is given.
There happens to be a single usage ":-" in ${rw:-rw} in
start-container-qemu.sh, where ":-" is actually needed.
Change-Id: Ibc8e070b698e1c76e2161eb65d40639b8cdec1f3
|
|
... to convert "--var val" and "++arr elem" arguments to variables.
Use in tcwg-upstream2gerrit.sh
Change-Id: I88bb8d6b366944626c71727227f12bdd33f7bb55
|
|
If false (default), send the patch(es) for review if they apply.
It true, only ask review if the patch(es) pass the filter: check if
the patch(es) contain anything dealing with arm, thumb, or aarch64.
Change-Id: I7dd0a9f175396bf898cdf9a696f275dff881fda7
|
|
So that we leave the repo in a clean state for the next run.
Change-Id: Ia5701e03ddca5dc009acd0691592cd6128336914
|
|
This does not work, since $patch_file is a tmp file, not managed by
git.
Change-Id: I027c34efcd29d1a9b01979d08d060874961715b1
|
|
Change-Id: I64d12c484ebb262bf3c6a031a4b9b89d4b9ad85a
|
|
Change-Id: I158f1927126c8e9bac22a7ec5956bfa956989cd4
|
